Skip to content

[dashboard] Move PVC feature flag to context #11672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jul 27, 2022

Description

Move the persistent volume claim feature flag into the FeatureFlagContext.

Refactor the context so that we have a simple, uniform way to add new dashboard feature flags.

Related Issue(s)

Closes #11609

How to test

All feature flags still work as before.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@andrew-farries andrew-farries requested a review from a team July 27, 2022 06:43
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-move-pvc-feature-flag.7 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit f46c742 into main Jul 27, 2022
@roboquat roboquat deleted the af/move-pvc-feature-flag branch July 27, 2022 12:07
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dashboard FeatureFlagContext to retrieve and make feature flags available
3 participants