Skip to content

Add label to differentiate backup/restore total/failure is PVC or GCS #11723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add label to differentiate backup/restore total/failure is PVC or GCS #11723

merged 1 commit into from
Jul 28, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jul 28, 2022 •
edited
Loading

Description

Add label to differentiate backup/restore total/failure is PVC or GCS

Related Issue(s)

Fixes #11722

How to test

  1. Launch workspace and write some file
  2. Stop workspace and reopen workspace
  3. Check the ws-manager metric curl -XGET localhost:9500/metrics
  4. Verify that the following metrics with the label pvc is false and the counter increase
  • gitpod_ws_manager_workspace_backups_failure_total
  • gitpod_ws_manager_workspace_backups_total
  • gitpod_ws_manager_workspace_restores_failure_total
  • gitpod_ws_manager_workspace_restores_total
  1. Enable feature flag PVC
  2. Rerun steps 1-3
  3. Verify that the following metrics with the label pvc is true and the counter increase
  • gitpod_ws_manager_workspace_backups_failure_total
  • gitpod_ws_manager_workspace_backups_total
  • gitpod_ws_manager_workspace_restores_failure_total
  • gitpod_ws_manager_workspace_restores_total

After that, we could use the label pvc is false or true to differentiate whether the backup/restore is by GCS or PVC.

Examples:
image
image

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

@jenting jenting marked this pull request as ready for review July 28, 2022 13:09
@jenting jenting requested a review from a team July 28, 2022 13:09
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 28, 2022
@roboquat roboquat merged commit 347af9b into main Jul 28, 2022
@roboquat roboquat deleted the jenting/metrics branch July 28, 2022 23:12
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

observability: GCS vs PVC backup/restore success rate
3 participants
@jenting @sagor999 @roboquat