When starting a workspace but usage attribution is unclear, prompt for explicit user choice #11777
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Copyright (c) 2022 Gitpod GmbH. All rights reserved. | ||
| * Licensed under the GNU Affero General Public License (AGPL). | ||
| * See License-AGPL.txt in the project root for license information. | ||
| */ | ||
|
|
||
| import { useContext, useEffect, useState } from "react"; | ||
| import { Team } from "@gitpod/gitpod-protocol"; | ||
| import { AttributionId } from "@gitpod/gitpod-protocol/lib/attribution"; | ||
| import { getGitpodService } from "../service/service"; | ||
| import { TeamsContext } from "../teams/teams-context"; | ||
| import { UserContext } from "../user-context"; | ||
| import SelectableCardSolid from "../components/SelectableCardSolid"; | ||
| import { ReactComponent as Spinner } from "../icons/Spinner.svg"; | ||
|
|
||
| export function BillingAccountSelector(props: { onSelected?: () => void }) { | ||
| const { user, setUser } = useContext(UserContext); | ||
| const { teams } = useContext(TeamsContext); | ||
| const [teamsWithBillingEnabled, setTeamsWithBillingEnabled] = useState<Team[] | undefined>(); | ||
|
|
||
| useEffect(() => { | ||
| if (!teams) { | ||
| setTeamsWithBillingEnabled(undefined); | ||
| return; | ||
| } | ||
| const teamsWithBilling: Team[] = []; | ||
| Promise.all( | ||
| teams.map(async (t) => { | ||
| const subscriptionId = await getGitpodService().server.findStripeSubscriptionIdForTeam(t.id); | ||
| if (subscriptionId) { | ||
| teamsWithBilling.push(t); | ||
| } | ||
| }), | ||
| ).then(() => setTeamsWithBillingEnabled(teamsWithBilling)); | ||
| }, [teams]); | ||
|
|
||
| const setUsageAttributionTeam = async (team?: Team) => { | ||
| if (!user) { | ||
| return; | ||
| } | ||
| const usageAttributionId = AttributionId.render( | ||
| team ? { kind: "team", teamId: team.id } : { kind: "user", userId: user.id }, | ||
| ); | ||
| await getGitpodService().server.setUsageAttribution(usageAttributionId); | ||
| setUser(await getGitpodService().server.getLoggedInUser()); | ||
| if (props.onSelected) { | ||
| props.onSelected(); | ||
| } | ||
| }; | ||
| return ( | ||
| <> | ||
| {teamsWithBillingEnabled === undefined && <Spinner className="m-2 h-5 w-5 animate-spin" />} | ||
| {teamsWithBillingEnabled && ( | ||
| <div> | ||
| <p>Bill all my usage to:</p> | ||
| <div className="mt-4 flex space-x-3"> | ||
| <SelectableCardSolid | ||
| className="w-36 h-32" | ||
| title="(myself)" | ||
| selected={ | ||
| !teamsWithBillingEnabled.find( | ||
| (t) => | ||
| AttributionId.render({ kind: "team", teamId: t.id }) === | ||
| user?.usageAttributionId, | ||
| )?.name | ||
| } | ||
| onClick={() => setUsageAttributionTeam(undefined)} | ||
| > | ||
| <div className="flex-grow flex items-end p-1"></div> | ||
| </SelectableCardSolid> | ||
| {teamsWithBillingEnabled.map((t) => ( | ||
| <SelectableCardSolid | ||
| className="w-36 h-32" | ||
| title={t.name} | ||
| selected={ | ||
| !!teamsWithBillingEnabled.find( | ||
| (t) => | ||
| AttributionId.render({ kind: "team", teamId: t.id }) === | ||
| user?.usageAttributionId, | ||
| )?.name | ||
| } | ||
| onClick={() => setUsageAttributionTeam(t)} | ||
| > | ||
| <div className="flex-grow flex items-end p-1"></div> | ||
| </SelectableCardSolid> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jankeromnes, I bet this is not the single place, where we'd need this kind of info. have you considered promoting this flag to the result of getTeams?
team.isBillingEnabledwould be nice and it shave off the additional requests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexTugarev I think this would be premature, because:
getTeamsload all the team subscriptions on every call, even when most callers don't need that currently