Skip to content

Detach dangling base mounts #11802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Detach dangling base mounts #11802

merged 1 commit into from
Aug 2, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 2, 2022

Description

As a last ditch effort detach base mounts if they cannot be unmounted. That way new accesses are denied and it will be unmounted once all processes are done using it.

Related Issue(s)

Related to #11369

Release Notes

None

Werft options:

  • /werft with-preview

@Furisto Furisto requested a review from a team August 2, 2022 10:44
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 2, 2022
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold it'd be good to be double reviewed by other team members.

@roboquat roboquat merged commit 2ec4178 into main Aug 2, 2022
@roboquat roboquat deleted the fo/detach-mount branch August 2, 2022 19:27
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants