[server] better handle workspacePageClose endpoint response status and log ctx

[mustard-mh]

Description

In previous PR, we did not handle the json-rpc response status #11643 (comment) of server instance and sharing workspace access #11643 (comment), this PR will handle it and add proper log context #11643 (comment)

We removed accessGuard of sharing, see reason in How to test section

Related Issue(s)

Fixes #

How to test

Check if it will process with sharing workspace or not

No need to test with sharing, since sharing workspace have no update permission on instance which server sendHeartbeat required. This is as expected.

gitpod/components/server/src/auth/resource-access.ts

Lines 265 to 276 in c18dea6

	export class SharedWorkspaceAccessGuard implements ResourceAccessGuard {
	async canAccess(resource: GuardedResource, operation: ResourceAccessOp): Promise<boolean> {
	switch (resource.kind) {
	case "workspace":
	return operation == "get" && resource.subject.shareable === true;
	case "workspaceInstance":
	return operation == "get" && !!resource.workspace.shareable;
	default:
	return false;
	}
	}
	}

gitpod/components/server/src/workspace/gitpod-server-impl.ts

Line 885 in c18dea6

await this.guardAccess({ kind: "workspaceInstance", subject: wsi, workspace: ws }, "update");

Can't test with response status code since all errors thrown in send heartbeat ends with "does not exist".

gitpod/components/server/src/workspace/gitpod-server-impl.ts

Line 905 in c18dea6

if (e.message && typeof e.message === "string" && (e.message as String).endsWith("does not exist")) {

Release Notes

NONE

Documentation

Werft options:

• /werft with-preview

[werft-gitpod-dev-com]

started the job as gitpod-build-hw-hb-s-2.1 because the annotations in the pull request description changed
(with .werft/ from main)

[geropl]

🧡

[geropl]

Code changes LGTM! 👍

[iQQBot]

LGTM