You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jenting I kind of disagree with this change.
We will end up marking workspace several times, no?
Since finalizeWorkspaceContent will be called several times.
Also, if we were not able to connect to ws-daemon, then we did not actually started finalize process. But this change would have marked workspace as already started finalize.
@jenting I kind of disagree with this change. We will end up marking workspace several times, no? Since finalizeWorkspaceContent will be called several times. Also, if we were not able to connect to ws-daemon, then we did not actually started finalize process. But this change would have marked workspace as already started finalize.
Thanks for the feedback @sagor999
After rethinking, I agree with you. I create a PR to revert it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roboquat
added
deployed: workspace
Description
Add annotation gitpod.io/startedDisposal once we enter finalize workspace content.
Related Issue(s)
Related #11710
How to test
None
Release Notes
Documentation
None
Werft options: