Skip to content

[dashboard] Fix displaying of logs for finished Prebuilds #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Aug 3, 2022

Description

Fix a bug where we do not load Prebuild logs when the prebuild has already finished.

Related Issue(s)

Fixes #11755

How to test

  • join this team
  • modify this line
  • check that the prebuild is executed
  • once it's "READY", go to the PrebuildDetails page (click the status) and notice how the logs are shown as well

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl
Copy link
Member Author

geropl commented Aug 3, 2022

/werft run

👍 started the job as gitpod-build-gpl-11755-logs.2
(with .werft/ from main)

with flag

@geropl geropl marked this pull request as ready for review August 3, 2022 09:21
@geropl geropl requested a review from a team August 3, 2022 09:21
@geropl geropl requested a review from laushinka August 3, 2022 09:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 3, 2022
@geropl
Copy link
Member Author

geropl commented Aug 3, 2022

@laushinka Could you take a look and review this one? I think you have most context here. 🙏

@laushinka laushinka self-assigned this Aug 3, 2022
@laushinka
Copy link
Contributor

laushinka commented Aug 3, 2022

Works as advertised! Thanks for the fix 🙌🏽

@roboquat roboquat merged commit 81c7aa1 into main Aug 3, 2022
@roboquat roboquat deleted the gpl/11755-logs branch August 3, 2022 10:34
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Prebuild Page Shows Nothing Where I Believe Logs Should Show Up
3 participants