-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor EntitlementService and extract License from Chargebee (2/3) #11889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f728537
to
5a7d837
Compare
started the job as gitpod-build-gpl-entitlement-svc-3.3 because the annotations in the pull request description changed |
5a7d837
to
320d3d0
Compare
@geropl, I couldn't set workspace timeout after switching to a paid plan (PRO) on https://alextugarev-bel-eka8ju26132.ws.gpl-entitl342918dfed.preview.gitpod-dev.com/
|
@AlexTugarev let's meet, what branch is that? 🤔 |
Thanks for clarifying. It's the Unleashed plan which is needed to enable the extended workspace timeout. |
Description
This again is a refactor with the aim to have 0 behavior changes. It's best reviewed in Gitpod method by method of this change.
There are two changes in call hierarchy, which makes this PR a non 100% move op:
The behavior of UserService.* has been folded into the new one be extracting that code into
EntitlementServiceLicense
. As thoseEntitlementService.*
methods have only been called by UserService, it's guaranteed to not change behavior. 🧘Related Issue(s)
Context: #11402
How to test
setup
License
Chargebee
Release Notes
Documentation
Werft options: