-
Notifications
You must be signed in to change notification settings - Fork 1.3k
EntitlementService Usage-Based Pricing #11936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jankeromnes @AlexTugarev This should build now. Can be moved to "ready for review" after #11814 has been merged, and this PR has been rebased on that! 👍 |
bdbe617
to
1030363
Compare
1030363
to
575e354
Compare
Got a inversify dependency cycle on
which seems to be unrelated to this PR changes on first look. Quickly checked with current main's state to rule out issues from there, and updated once more. |
/werft run 👍 started the job as gitpod-build-gpl-ets-ubb.5 |
'Wasted 1h of debugging in the wrong direction. Turns out the problematic import is Ah, |
c6db4d8
to
3d64d7c
Compare
3d64d7c
to
4980bbd
Compare
bd874fd
to
932f055
Compare
|
||
protected async hasPaidSubscription(user: User, date: Date): Promise<boolean> { | ||
// TODO(gpl) UBP personal: implement! | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: As currently implemented, it reads like everyone on Usage-Based gets XL workspaces.
d437f70
to
b0b4d88
Compare
Problematic situation:
In the team, I'm able to view the Usage-Based UI (e.g. Usage, Billing), but if I click on upgrade, the credit card form does not show up. That's because the API methods Possible solutions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks @geropl and @AlexTugarev for completing this big work item.
The code looks good to me, and after testing it, it seems that all the Chargebee flows work as well as before (with one slight worry about the out-of-hour situation).
Approving so that this lands, and so that we can test all the recent changes together on staging before they go live tomorrow morning. 🤞
Allegory of this PR: 💣🛹 (a skateboard that makes me nervous 😅)
Description
Based on: #11814
hasPaidSubscription
: 55c01f7#diff-fd2c4594d5bd9aa04668bdce9e9c810d3c495192a0be434006c7181f4853260bR93BillingService.checkSpendingLimitReached
(based on usage until Implement BillingService.GetLatestInvoice #11692 got merged)#BillingService
(commit)Related Issue(s)
Fixes #11402
How to test
Actually, after #11814 has been tested thoroughly, this can be tested in prod by enableing
isUsageBasedPricingEnabled
, and testing the rollout flow. 🙃Release Notes
Documentation
Werft options: