Skip to content

Add clusterrolebinding to allow kube-rbac-proxy verify tokens #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions install/installer/cmd/testdata/render/customization/output.golden
Original file line number Diff line number Diff line change
Expand Up @@ -2215,6 +2215,15 @@ data:
name: content-service
namespace: default
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
---
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -5172,6 +5181,24 @@ subjects:
name: blobserve
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-content-service-rb-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: default-kube-rbac-proxy
subjects:
- kind: ServiceAccount
name: content-service
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-ide-metrics-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1995,6 +1995,15 @@ data:
name: content-service
namespace: default
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
---
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -4612,6 +4621,24 @@ subjects:
name: blobserve
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-content-service-rb-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: default-kube-rbac-proxy
subjects:
- kind: ServiceAccount
name: content-service
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-ide-metrics-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand Down
27 changes: 27 additions & 0 deletions install/installer/cmd/testdata/render/minimal/output.golden
Original file line number Diff line number Diff line change
Expand Up @@ -2101,6 +2101,15 @@ data:
name: content-service
namespace: default
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
---
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -4851,6 +4860,24 @@ subjects:
name: blobserve
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-content-service-rb-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: default-kube-rbac-proxy
subjects:
- kind: ServiceAccount
name: content-service
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-ide-metrics-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2113,6 +2113,15 @@ data:
name: content-service
namespace: default
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
---
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -4863,6 +4872,24 @@ subjects:
name: blobserve
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-content-service-rb-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
creationTimestamp: null
labels:
app: gitpod
component: content-service
name: default-content-service-rb-kube-rbac-proxy
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: default-kube-rbac-proxy
subjects:
- kind: ServiceAccount
name: content-service
namespace: default
---
# rbac.authorization.k8s.io/v1/ClusterRoleBinding default-ide-metrics-kube-rbac-proxy
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,24 @@ func rolebinding(ctx *common.RenderContext) ([]runtime.Object, error) {
Kind: "ServiceAccount",
Name: Component,
}},
}}, nil
}, &rbacv1.ClusterRoleBinding{
TypeMeta: common.TypeMetaClusterRoleBinding,
ObjectMeta: metav1.ObjectMeta{
Name: fmt.Sprintf("%s-%s-rb-kube-rbac-proxy", ctx.Namespace, Component),
Labels: common.DefaultLabels(Component),
},
RoleRef: rbacv1.RoleRef{
Kind: "ClusterRole",
Name: fmt.Sprintf("%s-kube-rbac-proxy", ctx.Namespace),
APIGroup: "rbac.authorization.k8s.io",
},
Subjects: []rbacv1.Subject{
{
Kind: "ServiceAccount",
Name: Component,
Namespace: ctx.Namespace,
},
},
},
}, nil
}