Polish handling of BillingMode

[geropl]

Description

This PR includes a couple of alignments around BillingMode. It's reviewable by commit. As all changes share the same context I think it does not make sense to further split this up. 🧘

1. Improved tests + additional tests (no change in behavior)
2. Make "workspace classes" usable if either of these are true:
   1. You have the "workspace_classes" FF enabled
   2. The method BillingMode.canSetWorkspaceClass returns true for your BillingMode
3. Small fix to BillingModes: Only have paid UBP team memberships override existing Chargebee memberships
4. Handle bad "CostCenter" error, in case you have not yet set a team spending limit for whatever reason
5. Make moment time offset work on Usage List View removed
6. Fix wrong usage of findCustomerByUserId and replace with findCustomerByTeamId

Related Issue(s)

Fixes #12098
Fixes #12090
Fixes #12149

How to test

• signup
• create a Team called Gitpod-heroes or so
• check:
  • user preferences: no workspace classes selector, yet ✔️
  • user billing: no Usage-based stuff, yet ✔️
  • user settings menu: still has entries for Plans/Team Subscriptions ✔️
• try to start a workspace: shows the "set spending limit" UI ✔️
• signup for a Usage-Based team plan
  • user preferences: see workspace classes selector, yet ✔️
  • user billing: see the UBP attribution selector ✔️
  • user settings menu: no entries for Plans/Team Subscriptions ✔️

Release Notes

NONE

Documentation

Werft options:

• /werft with-preview
• /werft with-payment

[geropl]

/werft run

👍 started the job as gitpod-build-gpl-ubp.2
(with .werft/ from main)

[werft-gitpod-dev-com]

started the job as gitpod-build-gpl-ubp.3 because the annotations in the pull request description changed
(with .werft/ from main)

[jankeromnes]

Thanks! Code looks good, now moving on to (manual) tests.

[jankeromnes]

Question:

1. I have no paid plans, but am by default in Chargebee mode
2. I create a team called "Gitpod Something", which enables Usage-Based for both myself and my team
3. In my team, I now see the Usage-Based Billing UI, which is great 👍
4. However, in my user, I still only see the Chargebee UI

• Is this expected?
• How will I be able to upgrade my user to individual Usage-Based Billing (once that's supported)?

[geropl]

/hold Have to remove the usage timestamp fix commit as it clashes with a parallel fix.

[geropl]

We discussed @jankeromnes comment above: It's very well possible to not have UBP on your user. In this case, because the Team had not paid plan, yet.

[geropl]

/unhold

Commit removed.

@jankeromnes PR should be good to review - sorry for the UI glitch 🙇

[jankeromnes]

Many thanks for finishing up this PR @geropl! I went through the entire "How to test" process, but found a few possible small problems.

How to test

• signup

Right after signup, and a second time later after randomly refreshing once (but it's hard to reproduce), I got this strange error:

I believe this is when a backend service returns an error, but it's missing an HTTP error code (it's supposed to say something like Error 500, but instead it's just Error with a space but no error code).

But maybe it's just a preview problem and not related to this PR?

• create a Team called Gitpod-heroes or so

✅

Additionally, this wasn't part of the test flow, but I notice that the Team Billing UI has some unfortunate flickering:

https://youtu.be/v-x4zhj25pA

Instead of briefly showing the Chargebee UI before the Usage-Based UI shows up, I think this initial state should be a loading indicator. Can be done in a follow-up though.

• check:
  • user preferences: no workspace classes selector, yet ✔️

❌ Actually, there is this:

Is this not expected?

• user billing: no Usage-based stuff, yet ✔️

✅ (although I think this should change in the future when we implement usage-based billing for individual users)

• user settings menu: still has entries for Plans/Team Subscriptions ✔️

✅

• try to start a workspace: shows the "set spending limit" UI ✔️

❌ It didn't show the "set spending limit" UI, but started a workspace successfully instead:

• signup for a Usage-Based team plan
  • user preferences: see workspace classes selector, yet ✔️

✅ (selector is still visible)

• user billing: see the UBP attribution selector ✔️

❔ basically worked, although I needed to hard-refresh once in order to see the "Billing" menu entry (instead of the "Plans" and "Team Plans" entries which were still there for some reason).

After that single refresh, everything is there, although the "Billing" menu entry now takes a long time before it shows up.

• user settings menu: no entries for Plans/Team Subscriptions ✔️

✅ (same as above -- menu is eventually correct, but it takes a long time before the "Billing" menu entry shows up)

[geropl]

Thank you for your thorough review, @jankeromnes ! 🚀

Is this not expected?

The value of the workspace_classes FF changed in the meantime: 🙈

So this is expected, yes - but makes it hard to test. 🙄 We could add an exlusion case there... or try again with a [email protected] user.

Instead of briefly showing the Chargebee UI before the Usage-Based UI shows up, I think this initial state should be a loading indicator. Can be done in a follow-up though.

grey_question basically worked, although I needed to hard-refresh once in order to see the "Billing" menu entry (instead of the "Plans" and "Team Plans" entries which were still there for some reason).

Would you have time after 10:30 to help me fix these? 🙏 Feels like it could be simple, but I'm too unfamiliar with the Dashboard to be confident.

I believe this is when a backend service returns an error, but it's missing an HTTP error code (it's supposed to say something like Error 500, but instead it's just Error with a space but no error code).

Are there any logs on the server pod? 🤔

[jankeromnes]

So this is expected, yes - but makes it hard to test. 🙄 We could add an exlusion case there... or try again with a [email protected] user.

I tried with a [email protected] user -- same problem:

1. Initially, preferences has no workspace class selector
2. After creating a "Gitpod (Something)" team, preferences has a workspace class selector (contrary to test plan)
3. After upgrading team to usage-based subscription, workspace class selector remains in preferences

Would you have time after 10:30 to help me fix these? 🙏 Feels like it could be simple, but I'm too unfamiliar with the Dashboard to be confident.

Would be more than happy to! 👍 🎨

Are there any logs on the server pod? 🤔

I didn't check for server errors, but I'm pretty sure the /sorry/ redirect happens here:

gitpod/components/proxy/conf/Caddyfile

Lines 277 to 279 in aa2c51c

	handle_errors {
	redir https://{$GITPOD_DOMAIN}/sorry/#Error%20{http.reverse_proxy.status_text} 302
	}

[geropl]

@jankeromnes and I synced, and created this commit with resulting fixes. 👍

[jankeromnes]

Thanks @geropl!

Unfortunately, while doing one last check, I found another problem 🙈 it looks like the Chargebee team billing UI is now gone entirely:

https://youtu.be/oFNoS11vmuM

Notice that I have one team with UB flag enabled, and another team with UB flag disabled.

EDIT: However, when I delete the team with with UB enabled, it fixes the Charbebee UI of the team with UB disabled.

[jankeromnes]

Alright! I think we're there now. 🎉 Thanks for iterating until it works!

Approving to unblock merging, but holding because there is still one problem that I raised in this comment:

❌ It didn't show the "set spending limit" UI, but started a workspace successfully instead:

The testing plan says that, when you create a "Gitpod (Something)" team, and try to start a workspace, you get blocked by a "Spending Limit" modal.

This is not the case.

Instead, it continues to start workspaces with no issues, and I have to upgrade a team to Usage-Based, and then set a Spending Limit to very low (e.g. 0), in order to actually see the "Spending Limit" modal on workspace start.

However, this is likely a bug in the test scenario, and not a bug in the code, right? 😇

/hold

[geropl]

The testing plan says that, when you create a "Gitpod (Something)" team, and try to start a workspace, you get blocked by a "Spending Limit" modal.

This is not the case.

However, this is likely a bug in the test scenario, and not a bug in the code, right? innocent

I tested this before the rebase. As it's not critical, and more important that we don't show an arkward error message as before, I'd say let's merge this one (as it's big enough), and I will re-test and take care in a follow up.

Mentioned earlier, but here again: thank you for the through review @jankeromnes ! 🙏

[geropl]

/unhold