Skip to content

[server] trim rawEvents to avoid DB pollution #12167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

[server] trim rawEvents to avoid DB pollution #12167

merged 1 commit into from
Aug 17, 2022

Conversation

AlexTugarev
Copy link
Member

Description

This PR should fix handling of webhook events with large amount of changes attached as payload.

Related Issue(s)

Fixes #11578

How to test

  • Setup a projects and push a change to the repo. Webhook events should be received as usual.
  • Create an artificial change with a ton of files modified/added/removed. See that webhook events are captures without errors logged in server.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@AlexTugarev AlexTugarev requested a review from a team August 17, 2022 08:03
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 17, 2022
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Aug 17, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-trimrawevent.2
(with .werft/ from main)

@geropl geropl self-assigned this Aug 17, 2022
geropl
geropl approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and tested that webhooks still work. 💯

@roboquat roboquat merged commit 5f13138 into main Aug 17, 2022
@roboquat roboquat deleted the at/trimRawEvent branch August 17, 2022 15:54
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid accumulating large amounts of webhook event data in d_b_webhook_event
3 participants
@AlexTugarev @geropl @roboquat