[terraform] Add random variables to terrraform resource names #12385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
2201f5a to
0fd7460
Compare
nandajavarma
force-pushed
the
nvn/fix-tf-var-names
branch
from
fcf0922 to
6fad33f
Compare
nandajavarma
changed the base branch from
nvn/fix-cron-files
to
nvn/integ-flag
nandajavarma
changed the base branch from
nvn/integ-flag
to
nvn/fix-cron-files
nandajavarma
force-pushed
the
nvn/fix-tf-var-names
branch
from
6fad33f to
68e3e38
Compare
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
0fd7460 to
3ecbe48
Compare
nandajavarma
force-pushed
the
nvn/fix-tf-var-names
branch
2 times, most recently
from
9288929 to
a13f1bb
Compare
mrsimonemms
reviewed
Aug 31, 2022
| @@ -102,6 +110,7 @@ module "eks" { | |||
| enable_bootstrap_user_data = true | |||
| instance_types = [var.service_machine_type] | |||
| name = "service-${var.cluster_name}" | |||
| iam_role_name = format("%s-%s", substr("${var.cluster_name}-svc-ng", 0, 58), random_string.ng_role_suffix.result) | |||
There was a problem hiding this comment.
Am I correct in reading that this it to make a string a max of 62 characters long, always ending -svc-ng-<4-random-chars>?
There was a problem hiding this comment.
that is correct. I believe that is the max char limit.
mrsimonemms
reviewed
Aug 31, 2022
| export resource=$$(echo "$$TF_VAR_TEST_ID" | sed "s/[\\W\\-]//") && \ | ||
| az aks get-credentials --name gitpod-test-nor-primary-$$resource --resource-group gitpod-test-nor-$$resource --file ${KUBECONFIG} || echo "No cluster present" | ||
| export resource=$$(echo "$$TF_VAR_TEST_ID" | sed "s/[\\W\\-]//g") && \ | ||
| az aks get-credentials --name test-cluster-$$resource --resource-group sh-test-$$resource --file ${KUBECONFIG} || echo "No cluster present" |
There was a problem hiding this comment.
Can you use the terraform output command instead? Something like...
Suggested change
| az aks get-credentials --name test-cluster-$$resource --resource-group sh-test-$$resource --file ${KUBECONFIG} || echo "No cluster present" | |
| az aks get-credentials --name $(terraform output -json <name> | jq -r '.') --resource-group $(terraform output -json <name> | jq -r '.') --file ${KUBECONFIG} || echo "No cluster present" |
There was a problem hiding this comment.
This would involve changing the AKS terraform module output too. Do you mind if I take this up on a follow-up? I have to refactor the AKS module soon once the reference architecture is out.
mrsimonemms
approved these changes
Aug 31, 2022
nandajavarma
force-pushed
the
nvn/fix-cron-files
branch
from
3ecbe48 to
61a7be3
Compare
nandajavarma
force-pushed
the
nvn/fix-tf-var-names
branch
from
a13f1bb to
fc9fc8c
Compare
|
/unhold The extraction of name from |
nandajavarma
force-pushed
the
nvn/fix-tf-var-names
branch
from
fc9fc8c to
c5c9c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is basically the same changes @adrienthebo opened here #12321
The PR was unfortunately merged to a different branch, and this is an effort to split up the PR again to ease the review since it ended up becoming really big.
The main goal of this change is to make sure re-using the same state continues to work. So for starters things like database names cannot be re-used across most cloud providers for a week after the deletion, etc. Hence, the change @adrienthebo suggested adds a random variable to the end of resource names. Moreover, if a kubernetes cluster already exists by the name, the cluster creation is skipped and re-installation of KOTS is proceeded.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: