Skip to content

Expire spending limit notifications #12467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

AlexTugarev
Copy link
Member

and do not block on empty state.

Description

Related Issue(s)

Fixes #12094

How to test

  • enable UBB on a team; set a low spending limit (e.g. 1 or 2)
  • change attribution to team
  • create a project
  • start a couple of workspaces
  • turn to the dashboard and see the notification is shown on reload (it might take a couple of tries, to get the data fly through different systems)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

and do not block on empty state.
@AlexTugarev AlexTugarev requested a review from a team August 29, 2022 11:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 29, 2022
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Aug 29, 2022

/werft run

👍 started the job as gitpod-build-alex-spending-limit-notifications-12094.1
(with .werft/ from main)

@geropl geropl self-assigned this Aug 29, 2022
@geropl
Copy link
Member

geropl commented Aug 29, 2022

@AlexTugarev I'm testing, and I'm not sure it works as expected:

  • I set the spending limit to "1"
  • I see 0,5 credits on usage view
  • I see the "spending limit reached" notification
    image

Is that just the delay of the usage record? Or something else at play here? 🤔 (by now my usage is beyond 1 already)

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Aug 29, 2022

@geropl, this works as expected indeed! We need to align our Total usage with what we end-up computing on stripe, i.e. we need to round 🆙

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works! 🎉

@roboquat roboquat merged commit 9fca9cc into main Aug 29, 2022
@roboquat roboquat deleted the alex/spending-limit-notifications-12094 branch August 29, 2022 13:42
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spending limit notifications do not appear
3 participants