Clean up webhook events #12472
Merged
Clean up webhook events #12472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-at-events-gc.1 because the annotations in the pull request description changed |
AlexTugarev
force-pushed
the
at/events-gc
branch
from
b9b51ac to
f798650
Compare
|
back to draft. just tested the query and |
AlexTugarev
force-pushed
the
at/events-gc
branch
from
f798650 to
847743e
Compare
|
I removed the problematic |
|
@geropl, maybe you want to have a look at this one? |
|
@AlexTugarev Will review now. |
geropl
reviewed
Aug 30, 2022
geropl
reviewed
Aug 30, 2022
by running a periodic garbage collector. This is a pattern we use for other resources. fixes #12430
AlexTugarev
force-pushed
the
at/events-gc
branch
from
847743e to
2a66cc5
Compare
|
/werft run 👍 started the job as gitpod-build-at-events-gc.5 |
|
build was failing for an unrelated issue with db-sync replication. restarted. |
|
/werft run 👍 started the job as gitpod-build-at-events-gc.6 |
geropl
approved these changes
Aug 31, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by running a periodic garbage collector. This is a pattern we use for other resources.
fixes #12430
Description
The way GC works is admittedly tricky, as it's an interplay between the periodic GC task and the
db-sync. Periodically this will mark a bunch of entries asdeleted, and we rely on thedb-syncto actually delete the entries.Because it's proven unreliable to mark entries as delete in the thousands, leaving them in the db for ever after a failure, the settings to mark as deleted periodically are: 600 entries every 6 minutes, which is a rate of ~200K/day and should not produce a lot of DB CPU usage.
Related Issue(s)
Fixes #12430
How to test
Release Notes
Documentation
Werft options: