Skip to content

Revert "Add clarification for werft annotations in the PR description" #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Aug 29, 2022

Reverts #12432

Turns out that Werft parses the attributes made in comments, so the PR means we add "with-payment", "with-preview" and "with-payment with-preview" by default (see example job from this PR)

Release Notes

none

@roboquat roboquat merged commit 2ceb672 into main Aug 29, 2022
@roboquat roboquat deleted the revert-12432-aa/template branch August 29, 2022 18:45
@vulkoingim
Copy link
Contributor

vulkoingim commented Aug 29, 2022

Of course it does 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants