[usage] Fix report to JSON conversion #12545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/usage-fix-report-json
branch
from
4a5ab24 to
56c1b01
Compare
andrew-farries
approved these changes
Aug 31, 2022
| return n.Time().UTC().MarshalJSON() | ||
| } | ||
|
|
||
| func (n *VarcharTime) UnmarshalJSON(data []byte) error { |
There was a problem hiding this comment.
Was adding this method necessary to fix the upload or just for the round-trip test?
There was a problem hiding this comment.
Was necessary for the report download to serialise correctly. We'd convert it into a string, but on unmarshal we'd try to put it into the VarcharTime struct which would fail
It was caused by marshalling "invalid" VarcharTime structs. Instances which would have the 0 timestamp and set the flag "invalid". This was because serializing as |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload of usage report fails with
"failed to marshal report to JSON: json: error calling MarshalJSON for type db.VarcharTime: unexpected end of JSON input", this fixes that issue.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: