-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Loadgen fixes #12567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loadgen fixes #12567
Conversation
@Furisto can you take this PR to the finish line? |
db00780
to
966c309
Compare
966c309
to
8cf4db3
Compare
@sagor999 PR has been updated |
/werft run with-preview 👍 started the job as gitpod-build-pavel-loadgen-fix.3 |
/werft run with-preview 👍 started the job as gitpod-build-pavel-loadgen-fix.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run loadgen on preview env with PVC workspace-preview-benchmark-pvc.yaml
, and it works well.
/hold for others to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple questions
repos: | ||
- cloneURL: https://github.com/Furisto/workspace-stress | ||
cloneTarget: main | ||
score: 20 | ||
workspaceImage: eu.gcr.io/gitpod-dev/dev/loadtest/workspace-stress:latest | ||
workspaceImage: registry.hub.docker.com/gitpod/workspace-full:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation to switch to Docker Hub? Also, I think this image should be a reference to something that was built by image builder, not dazzle. Looping in @aledbf (below) for posterity.
@@ -70,18 +73,18 @@ repos: | |||
- cloneURL: https://github.com/gitpod-io/template-typescript-node | |||
cloneTarget: master | |||
score: 20 | |||
workspaceImage: eu.gcr.io/gitpod-dev/workspace-images:dd3075638ccf424374cc9c681b3d2338908d07115b28e54856cd45604c33768c | |||
workspaceImage: registry.hub.docker.com/gitpod/workspace-full:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Furisto something seems off here, but I may be mistaken.
On the left is an image that was built by image builder, and persisted to our internal GCR
On the right is an image that was built by dazzle, and persisted to public docker hub, but would still need to be built by image builder to work in a workspace, relying on this could make loadgen "take longer"
@aledbf can you help clarify what is expected/proper here?
/unhold |
Description
Loadgen fixes for PVC use by @Furisto
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: