Skip to content

Loadgen fixes #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Loadgen fixes #12567

merged 2 commits into from
Sep 7, 2022

Conversation

sagor999
Copy link
Contributor

Description

Loadgen fixes for PVC use by @Furisto

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@sagor999 sagor999 requested a review from a team August 31, 2022 22:39
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 31, 2022
@sagor999
Copy link
Contributor Author

sagor999 commented Sep 1, 2022

@Furisto can you take this PR to the finish line?

@roboquat roboquat added size/M and removed size/S labels Sep 1, 2022
@roboquat roboquat added size/L and removed size/M labels Sep 1, 2022
@Furisto
Copy link
Member

Furisto commented Sep 1, 2022

@sagor999 PR has been updated

@jenting
Copy link
Contributor

jenting commented Sep 1, 2022

/werft run with-preview

👍 started the job as gitpod-build-pavel-loadgen-fix.3
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 1, 2022

/werft run with-preview

👍 started the job as gitpod-build-pavel-loadgen-fix.4
(with .werft/ from main)

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run loadgen on preview env with PVC workspace-preview-benchmark-pvc.yaml, and it works well.

/hold for others to review.

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions

repos:
- cloneURL: https://github.com/Furisto/workspace-stress
cloneTarget: main
score: 20
workspaceImage: eu.gcr.io/gitpod-dev/dev/loadtest/workspace-stress:latest
workspaceImage: registry.hub.docker.com/gitpod/workspace-full:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation to switch to Docker Hub? Also, I think this image should be a reference to something that was built by image builder, not dazzle. Looping in @aledbf (below) for posterity.

@@ -70,18 +73,18 @@ repos:
- cloneURL: https://github.com/gitpod-io/template-typescript-node
cloneTarget: master
score: 20
workspaceImage: eu.gcr.io/gitpod-dev/workspace-images:dd3075638ccf424374cc9c681b3d2338908d07115b28e54856cd45604c33768c
workspaceImage: registry.hub.docker.com/gitpod/workspace-full:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Furisto something seems off here, but I may be mistaken.

On the left is an image that was built by image builder, and persisted to our internal GCR

On the right is an image that was built by dazzle, and persisted to public docker hub, but would still need to be built by image builder to work in a workspace, relying on this could make loadgen "take longer"

@aledbf can you help clarify what is expected/proper here?

@jenting
Copy link
Contributor

jenting commented Sep 7, 2022

/unhold

@roboquat roboquat merged commit 131c70c into main Sep 7, 2022
@roboquat roboquat deleted the pavel/loadgen-fix branch September 7, 2022 01:44
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants