Skip to content

fix: Round of the elapsedMinutes of prebuilds #12573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix: Round of the elapsedMinutes of prebuilds #12573

merged 1 commit into from
Sep 1, 2022

Conversation

Siddhant-K-code
Copy link
Member

Description

This PR is for rounding off the elapsed minutes while prebuilding. More context - internal discussion

Related Issue(s)

Fixes Internal fix request

How to test

  • Open any New Workspace which has some prebuild saving with this current PR's build.
  • 👀 See the Message regarding time saved in prebuild in terminal.

Release Notes

NONE

Documentation

No

Werft options:

  • /werft with-preview

@Siddhant-K-code Siddhant-K-code requested a review from a team September 1, 2022 05:59
@github-actions github-actions bot removed the size/XS label Sep 1, 2022
mustard-mh
mustard-mh approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🧡

@roboquat roboquat merged commit 59e89b2 into main Sep 1, 2022
@roboquat roboquat deleted the fix/prebuild-elapsedMinutes-calcs branch September 1, 2022 09:46
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siddhant-K-code @mustard-mh @roboquat