[UBP] Show "running" for instances with no end time in the usage view #12575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the current time as the end time for usage records without an end time (ie running instances) is problematic because it can cause the usage view to show an instance as having run for longer than it really did. This makes it looks like the credits calculation for the instance is incorrect. For running usage records, simply return "running" rather than inventing a stopped time for them.
easyCZ
approved these changes
Sep 1, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the current time as the end time for usage records without an end time (ie running instances) is problematic because it can cause the usage view to show an instance as having run for longer than it really did. This makes it looks like the credits calculation for the instance is incorrect.
For running usage records, simply return "running" rather than inventing a stopped time for them.
See also related discussion on Slack (internal).
Related Issue(s)
Part of #12064
How to test
Release Notes
Documentation
Werft options: