Skip to content

[gitpod-protocol] move generation of go types to prebuilds and werft #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

[gitpod-protocol] move generation of go types to prebuilds and werft #12648

merged 1 commit into from
Sep 5, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 5, 2022 •
edited by loujaybee
Loading

Description

We need to keep them up to date. But it slows down each commit if done in git hook, so instead we do it in prebuilds and in leeway job on werft.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@akosyakov akosyakov requested a review from a team September 5, 2022 12:08
@akosyakov akosyakov requested a review from csweichel September 5, 2022 12:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat added the size/M label Sep 5, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 5, 2022
csweichel
csweichel approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

geropl
geropl approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Ah, this is where all the time went - THANK YOU!

@roboquat roboquat merged commit 9a6c79a into main Sep 5, 2022
@roboquat roboquat deleted the ak/dont_gen_types_in_git_hook branch September 5, 2022 16:00
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akosyakov @csweichel @geropl @roboquat