Skip to content

[db-sync] sync d_b_usage #12673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[db-sync] sync d_b_usage #12673

merged 1 commit into from
Sep 6, 2022

Conversation

svenefftinge
Copy link
Member

Description

Adds d_b_usage to the list of synced tables.
I intentionally didn't specify/add a deleted column, because we don't have a deletion mechanism in place, yet. I hope we will no longer use db-sync when we introduce it 😅

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@svenefftinge svenefftinge requested a review from a team September 6, 2022 07:46
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 6, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skimmed the code but I'm assuming you know db-sync is happy without the deletion column specified.

@roboquat roboquat merged commit c1bb9b1 into main Sep 6, 2022
@roboquat roboquat deleted the se/sync_db_usage branch September 6, 2022 07:54
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants