[usage] Filter out not started workspace instances #12696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Sep 6, 2022
| @@ -224,10 +223,8 @@ type WorkspaceInstanceForUsage struct { | |||
| Type WorkspaceType `gorm:"column:workspaceType;type:char;size:16;default:regular;" json:"workspaceType"` | |||
| UsageAttributionID AttributionID `gorm:"column:usageAttributionId;type:varchar;size:60;" json:"usageAttributionId"` | |||
|
|
|||
| CreationTime VarcharTime `gorm:"column:creationTime;type:varchar;size:255;" json:"creationTime"` | |||
There was a problem hiding this comment.
Removes these fields as they are just confusing. They did not get removed originally when we switched to stoppingTime
geropl
reviewed
Sep 6, 2022
| @@ -134,6 +134,7 @@ func ListWorkspaceInstancesInRange(ctx context.Context, conn *gorm.DB, from, to | |||
| Where( | |||
| conn.Where("wsi.stoppingTime >= ?", TimeToISO8601(from)).Or("wsi.stoppingTime = ?", ""), | |||
| ). | |||
| Where("wsi.startedTime != ?", ""). | |||
geropl
approved these changes
Sep 6, 2022
easyCZ
commented
Sep 6, 2022
| @@ -134,6 +134,7 @@ func ListWorkspaceInstancesInRange(ctx context.Context, conn *gorm.DB, from, to | |||
| Where( | |||
| conn.Where("wsi.stoppingTime >= ?", TimeToISO8601(from)).Or("wsi.stoppingTime = ?", ""), | |||
| ). | |||
| Where("wsi.startedTime != ?", ""). | |||
There was a problem hiding this comment.
This is where we filter out any without a started time
easyCZ
force-pushed
the
mp/usage-filter-out-not-started
branch
from
4b7c7b9 to
b0ff117
Compare
roboquat
added
deployed: webapp
1 task
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: