Skip to content

Update dev/ssh-load-test and dev/changelog go mod versions #12703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Sep 6, 2022

Description

GOCACHE gets corrupted due to old package versions that are being built and put in the cache at some point.

I'm almost certain that this should solve the problem.

@gitpod-io/engineering-workspace how is the cache populated? Is it done during a prebuild step? And is there a way to clean it?

How to test

Open a workspace and run:

 go install github.com/gitpod-io/observability/installer@main

# sigs.k8s.io/json/internal/golang/encoding/json
../go/pkg/mod/sigs.k8s.io/[email protected]/internal/golang/encoding/json/encode.go:158:16: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)

# github.com/google/btree
../go/pkg/mod/github.com/google/[email protected]/btree_generic.go:89:16: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)

This succeeds (takes a while):

GOCACHE=$(pwd)/cache go install -v github.com/gitpod-io/observability/installer@main

Release Notes

NONE

Werft options:

  • /werft with-preview

@vulkoingim
Copy link
Contributor Author

vulkoingim commented Sep 6, 2022

/werft run

👍 started the job as gitpod-build-aa-upd-gomod.0
(with .werft/ from main)

@ArthurSens
Copy link
Contributor

ArthurSens commented Sep 6, 2022

I'm not sure what is being changed here or exactly why this change is needed.

I'm almost certain that this should solve the problem.

If it doesn't, it should be fairly ok to revert the change, right? 🙂

Are you waiting for a response from team-workspace or just wants a rubber-stamp?

@vulkoingim
Copy link
Contributor Author

vulkoingim commented Sep 6, 2022

I'm not sure what is being changed here or exactly why this change is needed.

I'm almost certain that this should solve the problem.

If it doesn't, it should be fairly ok to revert the change, right? 🙂

Are you waiting for a response from team-workspace or just wants a rubber-stamp?

There should be no need for a revert. Not sure why those weren't updated.

A ✅ should suffice. The question towards the ws team is more for me understanding how it's built.

@roboquat roboquat merged commit 6b14c1e into main Sep 6, 2022
@roboquat roboquat deleted the aa/upd-gomod branch September 6, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants