Skip to content

Minor improvements to Werft slices #12842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Minor improvements to Werft slices #12842

merged 1 commit into from
Sep 9, 2022

Conversation

mads-hartmann
Copy link
Contributor

Description

This PR contains a few improvements to Werft slices

  • More granular slices for the "job preparation" phase. These are mostly interesting as they provide more detailed traces.
  • Added a slice that contains information about what node the job was scheduled on. This can help when you're debugging caching issues as the docker layer caching is node dependant
  • Pretty-printed the JSON configuration and "hid" it behind a "Expand to see the parsed configuration". This makes it less noisy visually, and more readable when you actually care about the contents of the config

Related Issue(s)

No issue. Friday fun times.

How to test

Before

Screenshot 2022-09-09 at 16 55 10

After

Screenshot 2022-09-09 at 16 54 58

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-preview

@mads-hartmann
Add more detailed slices
48b8032 
Also include a slice with the NODENAME and pretty print config json
@mads-hartmann mads-hartmann marked this pull request as ready for review September 9, 2022 14:57
@mads-hartmann mads-hartmann requested a review from a team September 9, 2022 14:57
ArthurSens
ArthurSens approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UI improvements :)

@roboquat roboquat merged commit 0a2d6db into main Sep 9, 2022
@roboquat roboquat deleted the mads/smaller-changes branch September 9, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
release-note-none size/M team: devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mads-hartmann @ArthurSens @roboquat