[usage] API for setting billingStrategy #12882
Conversation
|
@svenefftinge: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
started the job as gitpod-build-sefftinge-ubp-model-free-plan-and-12741.7 because the annotations in the pull request description changed |
| enum BillingStrategy { | ||
| BILLING_STRATEGY_STRIPE = 0; | ||
| BILLING_STRATEGY_OTHER = 1; | ||
| } |
There was a problem hiding this comment.
Because all fields in a protobuf message are optional, and protobuf defaults to the empty value, for Enums it will default to BILLING_STRATEGY_STRIPE in this struct, when not set. That's not always desirable, as if you forget to set it it will have adverse effects. For that reason, the UNKNOWN value is normally used in any enum (the RPC is then implemented to fail if the value is UNKNOWN.
| enum BillingStrategy { | |
| BILLING_STRATEGY_STRIPE = 0; | |
| BILLING_STRATEGY_OTHER = 1; | |
| } | |
| enum BillingStrategy { | |
| BILLING_STRATEGY_UNKNOWN = 0 | |
| BILLING_STRATEGY_STRIPE = 1; | |
| BILLING_STRATEGY_OTHER = 2; | |
| } |
| summary, err := db.GetUsageSummary(ctx, s.conn, attributionID, time.Now(), time.Now(), false) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if summary.CreditCentsBalanceAtEnd.ToCredits() > float64(in.SpendingLimit) { | ||
| return nil, status.Errorf(codes.InvalidArgument, "The spending limit must be higher than the current usage %u", summary.CreditCentsBalanceAtEnd.ToCredits()) | ||
| } | ||
|
|
||
| //TODO (se) - Check if the strategy has changed and was 'other' before. If so run the invoice finalization. | ||
| _, err = db.SaveCostCenter(ctx, s.conn, &db.CostCenter{ | ||
| ID: attributionID, | ||
| SpendingLimit: in.CostCenter.SpendingLimit, | ||
| SpendingLimit: in.SpendingLimit, | ||
| BillingStrategy: billingStrategy, | ||
| }) |
There was a problem hiding this comment.
There's a possible race here due to write after read semantics, but I think in our case we don't actually need to handle it as we'll recoup it in the next billing cycle.
| const currentInvoiceCredits = upcomingInvoice.getCredits(); | ||
| if (currentInvoiceCredits >= costCenter.spendingLimit) { | ||
| const currentInvoiceCredits = upcomingInvoice.credits | 0; | ||
| if (currentInvoiceCredits >= (costCenter.spendingLimit || 0)) { |
There was a problem hiding this comment.
rather than || 0 should we use the same defaultSpendingLimit as when the Stripe subscription is configured?
See this comment.
Description
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: