Skip to content

Revert "Revert "Improve layer caching by moving apk commands up"" #12907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

mads-hartmann
Copy link
Contributor

Description

This reverts commit e27e278 which was reverting ceb75eb

This original PR (#12834) was reverted because it changed the layers of the Installer Docker image which our ArgoCD SaaS deployment plugin was really sensitive to. This was fixed in https://github.com/gitpod-io/ops/pull/5115 so it is now save to revert the revert ☺️

Related Issue(s)

Fixes #12828

How to test

This was tested in the original PR #12834

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-preview

@mads-hartmann mads-hartmann requested a review from a team September 13, 2022 09:51
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 13, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold I'd like for @gitpod-io/engineering-webapp to also approve this as it broke their workflow last time - I don't want to have to revert the revert of the revert 😄

From my point of view, it's fine

@mrsimonemms mrsimonemms requested review from geropl and a team September 13, 2022 09:59
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 13, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine now, as we don't have a dependency on the layers anymore 🧘

@roboquat roboquat merged commit 40cb726 into main Sep 13, 2022
@roboquat roboquat deleted the mads/revert-revert branch September 13, 2022 10:10
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/XS team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build speed: Install/installer:docker
4 participants