Skip to content

[usage] Rename ReconcileUsageWithLedger to ReconcileUsage #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 13, 2022

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team September 13, 2022 13:08
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 13, 2022
@easyCZ easyCZ force-pushed the mp/usage-rename-reconcile-usage branch from c5a8c9a to 7b20b90 Compare September 13, 2022 13:18
@easyCZ easyCZ force-pushed the mp/usage-rename-reconcile-usage branch from 7b20b90 to 4744288 Compare September 13, 2022 13:47
@andrew-farries andrew-farries self-assigned this Sep 13, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might clash with #12903 as that uses a different tool to generate the typescript code from the .proto files.

/hold

@easyCZ
Copy link
Member Author

easyCZ commented Sep 13, 2022

I think this might clash with #12903 as that uses a different tool to generate the typescript code from the .proto files.

/hold

I'll make sure this is rebased.

@easyCZ
Copy link
Member Author

easyCZ commented Sep 13, 2022

Already rebased on latest.

@easyCZ
Copy link
Member Author

easyCZ commented Sep 13, 2022

/unhold

@roboquat roboquat merged commit c3673e3 into main Sep 13, 2022
@roboquat roboquat deleted the mp/usage-rename-reconcile-usage branch September 13, 2022 13:55
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants