[baseserver] Add metric with version of the server, use in public api and usage #13022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
force-pushed
the
mp/baseserver-report-server-version-in-metrics
branch
2 times, most recently
from
f1d54e5 to
8051afb
Compare
andrew-farries
approved these changes
Sep 16, 2022
| @@ -37,7 +37,7 @@ func run() *cobra.Command { | |||
| log.WithError(err).Fatal("Failed to get config. Did you specify --config correctly?") | |||
| } | |||
|
|
|||
| err = server.Start(cfg) | |||
| err = server.Start(cfg, Version) | |||
There was a problem hiding this comment.
I see that this Version is set during build, but how and where it is set and what is the format of the version string?
There was a problem hiding this comment.
I've observed either commit-<hash> or main.<build-id>
It's set by the CI job when it builds the images
easyCZ
force-pushed
the
mp/baseserver-report-server-version-in-metrics
branch
from
8051afb to
bfb957c
Compare
|
/hold to not block merge Q |
|
/werft run 👍 started the job as gitpod-build-mp-baseserver-report-server-version-in-metric.4 |
|
/unhold |
1 task
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be able to track which version we're on in our dashboards. Will produce the following metric:
Once validated, I can also add this to other instances of baseserver
The approach to the metric with version is standard, see docs
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: