[baseserver] Track metrics for HTTP requests automatically #13040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
from
e4adfc5 to
b9abb57
Compare
|
/werft run 👍 started the job as gitpod-build-mp-baseserver-http-metrics.3 |
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
from
b9abb57 to
e0ecbe8
Compare
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
from
e0ecbe8 to
1aecf45
Compare
github-actions
bot
added
the
team: delivery
|
/werft run 👍 started the job as gitpod-build-mp-baseserver-http-metrics.6 |
jenting
approved these changes
Sep 19, 2022
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
from
1aecf45 to
7dccee1
Compare
easyCZ
requested review from
aledbf,
sagor999,
csweichel and
akosyakov
as code owners
|
/werft run 👍 started the job as gitpod-build-mp-baseserver-http-metrics.8 |
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
2 times, most recently
from
9d856d0 to
670a0b9
Compare
|
/werft run 👍 started the job as gitpod-build-mp-baseserver-http-metrics.11 |
svenefftinge
approved these changes
Sep 19, 2022
sagor999
approved these changes
Sep 19, 2022
nandajavarma
approved these changes
Sep 20, 2022
easyCZ
force-pushed
the
mp/baseserver-http-metrics
branch
from
853f9cd to
276ae9d
Compare
roboquat
added
deployed: webapp
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've got automatic gRPC metric tracking on base-server, but for HTTP requests we've had nothing. This PR adds metrics for HTTP requests on baseserver.
This is needed to progress #13034 and ensure we can track failed Invoice Finalization webhooks going through
public-api.Ran
leeway run components:update-go-modulesto propagate it into dependenciesRelated Issue(s)
How to test
Release Notes
Documentation
Werft options: