[server] Delete prebuild records when purging workspaces #13152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/gc-delete-prebuilds
branch
2 times, most recently
from
da08869 to
a20e0b7
Compare
easyCZ
commented
Sep 21, 2022
geropl
reviewed
Sep 21, 2022
|
|
||
| @injectable() | ||
| export class MonitoringEndpointsAppEE extends WorkspaceHealthMonitoring { | ||
| @inject(WorkspaceHealthMonitoring) protected readonly workspaceHealthMonitoring: WorkspaceHealthMonitoring; | ||
|
|
||
| public create(): express.Application { | ||
| const registry = prometheusClient.register; |
geropl
reviewed
Sep 21, 2022
|
|
||
| // This column triggers the db-sync deletion mechanism. It's not intended for public consumption. | ||
| @Column() | ||
| deleted?: boolean; |
There was a problem hiding this comment.
The migration for this field is still missing, right?
Are you still working on this PR/should if be in "draft" mode? 🤔
There was a problem hiding this comment.
This one actually has the field, just wasn't in the db model. Yes, for the other ones we need the migrations. I'm moving the PR to draft.
There was a problem hiding this comment.
just wasn't in the db model
Oh really... 🙈
easyCZ
force-pushed
the
mp/gc-delete-prebuilds
branch
from
3765d1c to
ee39803
Compare
|
/werft run 👍 started the job as gitpod-build-mp-gc-delete-prebuilds.5 |
easyCZ
force-pushed
the
mp/gc-delete-prebuilds
branch
2 times, most recently
from
12ddbc7 to
92b2399
Compare
easyCZ
force-pushed
the
mp/gc-delete-prebuilds
branch
2 times, most recently
from
ccab82d to
a84edd1
Compare
easyCZ
force-pushed
the
mp/gc-delete-prebuilds
branch
from
a84edd1 to
45d866c
Compare
easyCZ
commented
Sep 22, 2022
| const registry = prometheusClient.register; | ||
|
|
||
| prometheusClient.collectDefaultMetrics({ register: registry }); | ||
| registerDBMetrics(registry); |
There was a problem hiding this comment.
This change was needed to keep the metrics defined in the gitpod-db package, but bind it to server.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we delete Workspaces, we also need to delete corresponding prebuilds when the Workspace is based on a prebuild.
Related Issue(s)
How to test
Release Notes
Documentation
Werft options:
Valid options are
all,workspace,webapp,ide