-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[usage] Align credits and time in usage view #13173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -310,7 +310,7 @@ function UsageView({ attributionId }: UsageViewProps) { | |||
</div> | |||
<div className="my-auto" /> | |||
<div className="flex flex-col col-span-3 my-auto"> | |||
<span className="text-gray-400 dark:text-gray-500 truncate font-medium"> | |||
<span className="text-gray-400 text-right dark:text-gray-500 truncate font-medium"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you also want to remove the truncate (elipses)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to do that later as I need to run for a meeting but if it's that simple, can do :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm talking about the truncation of the time property. See screenshot ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you removed the truncate for the 'usage' not the 'time'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I don't follow what you mean. I'm removing truncation from the number of minutes that a workspace ran (as per the issue), not the usage record timestamp.
In the preview env, it renders as below, which should be the expected outcome
2025087
to
93a15b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, adding hold in case you want to include the removal of 'truncate' on the time property
/hold
fd5f176
to
82efb17
Compare
82efb17
to
f5b1d81
Compare
/werft run with-preview 👍 started the job as gitpod-build-mp-usage-align-credits-time.5 |
I'm unholding this PR as the current form looks to solve the problem as required. Happy to do a follow-up. /unhold |
Description
Right-aligns credits and time in the usage view
Related Issue(s)
How to test
Release Notes
Documentation
Werft options:
Valid options are
all
,workspace
,webapp
,ide