Add PortsStatus::on_open #13189
Merged
Add PortsStatus::on_open #13189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
Sep 21, 2022
jeanp413
force-pushed
the
jp/on_open
branch
from
20f413c to
88dc545
Compare
|
Any context about why we need these changes? |
|
I synced with @akosyakov today and talked about ports in vscode and we need this info even if the port is not exposed so we can update Machine/settings.json |
akosyakov
force-pushed
the
jp/on_open
branch
from
88dc545 to
55ffd94
Compare
|
@mustard-mh I've updated the PR description to clarify for future readers. |
akosyakov
force-pushed
the
jp/on_open
branch
from
55ffd94 to
1c322cf
Compare
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of forwarding we need to know configuration in advance. Right now it is possible to get to grasp of it only when port is exposed. We deprecated on open action in the exposed state (ExposedPortInfo::on_exposed) and move to PortStatus itself (use PortsStatus::on_open instead).
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide