Skip to content

Only lint in install/kots:lint if env vars are set #13218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Only lint in install/kots:lint if env vars are set #13218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions WORKSPACE.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ defaultArgs:
golandDownloadUrl: "https://download.jetbrains.com/go/goland-2022.2.3.tar.gz"
pycharmDownloadUrl: "https://download.jetbrains.com/python/pycharm-professional-2022.2.2.tar.gz"
phpstormDownloadUrl: "https://download.jetbrains.com/webide/PhpStorm-2022.2.2.tar.gz"
REPLICATED_API_TOKEN: ""
REPLICATED_APP: ""
provenance:
enabled: true
slsa: true
Expand Down
2 changes: 1 addition & 1 deletion install/kots/BUILD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ packages:
- REPLICATED_APP
config:
commands:
- ["make", "helm", "lint"]
- ["make", "helm", "lint", "REPLICATED_API_TOKEN=${REPLICATED_API_TOKEN}", "REPLICATED_APP=${REPLICATED_APP}"]
6 changes: 5 additions & 1 deletion install/kots/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,9 @@ logo:
.PHONY: logo

lint:
replicated release lint --yaml-dir ${YAML_DIR}
@if [ "${REPLICATED_API_TOKEN}" != "" ] && [ "${REPLICATED_APP}" != "" ]; then \
replicated release lint --yaml-dir ${YAML_DIR}; \
else \
echo "REPLICATED_API_TOKEN and REPLICATED_APP are not set. Skipping"; \
fi
.PHONY: lint