Skip to content

Revert "[usage] Use DefaultClientOptions when creating grpc client connection #13230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 23, 2022

This reverts commit 0f5d689.

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team September 23, 2022 08:28
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 23, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which option specifically caused the problem here?

@easyCZ
Copy link
Member Author

easyCZ commented Sep 23, 2022

Unsure yet, but reverting the change until I get a chance to investigate.

@roboquat roboquat merged commit 4a2648e into main Sep 23, 2022
@roboquat roboquat deleted the mp/revert-dialer-usage branch September 23, 2022 08:40
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants