Skip to content

[db-sync] Add extra columns to d_b_volume_snapshot table to allow sync #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { Transformer } from "../transformer";
@Entity()
@Index("ind_dbsync", ["creationTime"]) // DBSync
@Index("ind_workspaceId_creationTime", ["workspaceId", "creationTime"]) // findVolumeSnapshotForGCByWorkspaceId
// on DB but not Typeorm: @Index("ind_lastModified", ["_lastModified"]) // DBSync
export class DBVolumeSnapshot implements VolumeSnapshot {
@PrimaryColumn(TypeORM.WORKSPACE_ID_COLUMN_TYPE)
id: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/**
* Copyright (c) 2022 Gitpod GmbH. All rights reserved.
* Licensed under the GNU Affero General Public License (AGPL).
* See License-AGPL.txt in the project root for license information.
*/

import { MigrationInterface, QueryRunner } from "typeorm";
import { columnExists, indexExists } from "./helper/helper";

const TABLE_NAME = "d_b_volume_snapshot";
const DELETED_COLUMN_NAME = "deleted";
const MODIFIED_COLUMN_NAME = "_lastModified";
const LAST_MODIFIED_INDEX_NAME = "ind_lastModified";

export class AddLastModifiedToVolumeSnapshots1664205442175 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
if (!(await columnExists(queryRunner, TABLE_NAME, DELETED_COLUMN_NAME))) {
await queryRunner.query(
`ALTER TABLE ${TABLE_NAME} ADD COLUMN \`${DELETED_COLUMN_NAME}\` tinyint(4) NOT NULL DEFAULT '0', ALGORITHM=INPLACE, LOCK=NONE`,
);
}

if (!(await columnExists(queryRunner, TABLE_NAME, MODIFIED_COLUMN_NAME))) {
await queryRunner.query(
`ALTER TABLE ${TABLE_NAME} ADD COLUMN ${MODIFIED_COLUMN_NAME} timestamp(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6), ALGORITHM=INPLACE, LOCK=NONE `,
);
}

if (!(await indexExists(queryRunner, TABLE_NAME, LAST_MODIFIED_INDEX_NAME))) {
await queryRunner.query(
`CREATE INDEX \`${LAST_MODIFIED_INDEX_NAME}\` ON \`${TABLE_NAME}\` (${MODIFIED_COLUMN_NAME})`,
);
}
}

public async down(queryRunner: QueryRunner): Promise<void> {}
}