[db] Soft delete entries in the db_volume_snapshot table
#13391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
started the job as gitpod-build-af-soft-delete-in-volume-snapshot-table.6 because the annotations in the pull request description changed |
andrew-farries
force-pushed
the
af/soft-delete-in-volume-snapshot-table
branch
from
9033463 to
ee95f69
Compare
added 4 commits
September 29, 2022 07:21
Replace the existing hard-deletion of volume snapshot rows in the database with soft-deletion that will allow `db-sync` to propagate deletions between clusters.
For each workspaceId, add a deleted volume snapshot.
Filter out deleted volume snapshots from the result sets.
Add tests (`testCantFindDeletedVolumeSnapshotById` fails). The failing test is due to `findVolumeSnapshotById` not taking deleted entries into account.
andrew-farries
force-pushed
the
af/soft-delete-in-volume-snapshot-table
branch
from
aeb810b to
f598cc1
Compare
3 tasks
easyCZ
approved these changes
Sep 29, 2022
| return volumeSnapshots | ||
| .createQueryBuilder("vs") | ||
| .where("vs.deleted = 0") | ||
| .andWhereInIds(volumeSnapshotId) |
There was a problem hiding this comment.
What's the difference between findOne and andWhereInIds?
There was a problem hiding this comment.
Wondering the same. Using .andWhere("vs.id = :id", { id: volumneSnapshotId }) would be more direct, and require less TypeORM knowledge.
There was a problem hiding this comment.
Thanks, I've rebased to make this change.
Filter soft deleted entries out of the result set.
andrew-farries
force-pushed
the
af/soft-delete-in-volume-snapshot-table
branch
from
f598cc1 to
3f1dc66
Compare
sagor999
approved these changes
Sep 29, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the existing hard-deletion of rows in the
db_volume_snapshottable with soft-deletion.This will allow
db-syncto propagate deletions between clusters.Related Issue(s)
Follow up to #13348
Part of #9198
How to test
Unit tests
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide