[supervisor] support multi-line environment variable in ssh #13822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we use
~/.ssh/supervisor_env
to store user envvar in order to export to ssh terminal (it's required by vscode desktop and some user case)But there have some problems with that, it's don't support multi-line environments (some thing like rsa private key...), if you set an environment variable with a multi-line value, you may cannot connection via ssh
This PR remove
~/.ssh/supervisor_env
logic, instead we useSetEnv
argument to support that.Related Issue(s)
Fixes #13592
How to test
gp env
to set a multi-line envenv
andexport
to see multi-line environment variable is workvscode desktop
, it should work same with beforeRelease Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide