Skip to content

[bridge] Extract WorkspaceInstanceController #13866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2022
Merged

[bridge] Extract WorkspaceInstanceController #13866

merged 2 commits into from
Oct 19, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Oct 14, 2022 •
edited
Loading

Description

Preparations in order to work on #6770:

  • make telepresence work again
  • fix a bug in how we configure preview envs (commit)
  • extract WorkspaceInstanceController from Bridge (code move only, zero function change)

Related Issue(s)

Context: #6770

How to test

  • open a workspace on this PR and see that the ws-manager-bridge deployment run without issues
  • check logs of ws-manager-bridge and not that there are no errors
  • start a workspace and notice how everything works as expected.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-6770-app-gc-1.1 because the annotations in the pull request description changed
(with .werft/ from main)

@geropl geropl mentioned this pull request Oct 14, 2022
Merged
3 tasks
@geropl
Copy link
Member Author

geropl commented Oct 14, 2022

While werft is not picking up the changes from commit regarding the preview envs, fixing it manually in the ConfigMaps works nicely:
image

@geropl geropl marked this pull request as ready for review October 14, 2022 14:27
@geropl geropl requested a review from a team October 14, 2022 14:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 14, 2022
easyCZ
easyCZ reviewed Oct 17, 2022
View reviewed changes
@geropl
Copy link
Member Author

geropl commented Oct 17, 2022

/hold until I applied the suggested changes/improved comments.

easyCZ
easyCZ approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clarifications (and explaining transient)

@andrew-farries andrew-farries mentioned this pull request Oct 18, 2022
Merged
3 tasks
@geropl geropl force-pushed the gpl/6770-app-gc-1 branch 2 times, most recently from 740618c to a4a8701 Compare October 19, 2022 08:07
@geropl geropl force-pushed the gpl/6770-app-gc-1 branch from a4a8701 to 0952ecb Compare October 19, 2022 08:47
@geropl
Copy link
Member Author

geropl commented Oct 19, 2022

/unhold

Applied the mentioned suggestions, rebased and re-tested: ✔️

@roboquat roboquat merged commit e2cfceb into main Oct 19, 2022
@roboquat roboquat deleted the gpl/6770-app-gc-1 branch October 19, 2022 08:57
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geropl @easyCZ @roboquat