Skip to content

[content-service] Make prebuild initializer more robust #13956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

[content-service] Make prebuild initializer more robust #13956

merged 1 commit into from
Oct 18, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Oct 18, 2022 •
edited by aledbf
Loading

against submodule update problems, and awry fetch situations.

Description

This PR

  • makes the prebuild content initializer more robust against submodule issues, by adopting the same error behaviour of the Git initializer,
  • removes the "fetch all branches and tags" behaviour in the prebuild initializer which was intended to ensure that we can checkout the clone target. Instead, we make a dedicated (no submodule recursing) fetch for the clone target.

Related Issue(s)

works on #9280

How to test

  • run the workspace integration tests to make sure we didn't break anything
  • deploy in production as see if the "content init failed" failures go down.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@csweichel
[content-service] Make prebuild initializer more robust
86c8f10 
against submodule update problems,
and awry fetch situations.
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-cw-maybe-fix-9280.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-cw-maybe-fix-9280.2 because the annotations in the pull request description changed
(with .werft/ from main)

@csweichel
Copy link
Contributor Author

csweichel commented Oct 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-cw-maybe-fix-9280.3
(with .werft/ from main)

@aledbf
Copy link
Member

aledbf commented Oct 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-cw-maybe-fix-9280.4
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-cw-maybe-fix-9280.5 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review October 18, 2022 20:04
@aledbf aledbf requested a review from a team October 18, 2022 20:04
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 18, 2022
@roboquat roboquat merged commit b2d94c0 into main Oct 18, 2022
@roboquat roboquat deleted the cw/maybe-fix-9280 branch October 18, 2022 20:05
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 19, 2022
@jenting jenting mentioned this pull request Oct 20, 2022
Closed
@kylos101 kylos101 mentioned this pull request Oct 21, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csweichel @aledbf @roboquat