[ws-manager] Fix potential leak of request body #13957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-aledbf-fixl.1 because the annotations in the pull request description changed |
|
started the job as gitpod-build-aledbf-fixl.4 because the annotations in the pull request description changed |
|
You need to rebase. This will fix the failing build. |
|
/werft run 👍 started the job as gitpod-build-aledbf-fixl.6 |
sagor999
approved these changes
Oct 18, 2022
roboquat
added
deployed: workspace
iQQBot
reviewed
Oct 23, 2022
| @@ -95,28 +125,13 @@ func (p *WorkspaceReadyProbe) Run(ctx context.Context) WorkspaceProbeResult { | |||
| continue | |||
| } | |||
|
|
|||
| if resp.StatusCode != http.StatusOK { | |||
| resp.Body.Close() | |||
There was a problem hiding this comment.
Where is the potential leak? It looks like we only have 2 exit point, one is here, and another one is below, both case all have resp.Body.Close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure we close the body of the request.
Modifies the change introduced in #13828
How to test
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide