-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] Fix display of billing period boundaries by using only UTC times #14088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-jx-fix-billing-period-ui.1 because the annotations in the pull request description changed |
9840410
to
11a3161
Compare
To use dayjs, we can use https://day.js.org/docs/en/manipulate/utc |
Many thanks @easyCZ for taking the time to propose a I'll take a look at your proposed changes, and pull them in if I see no issue with them. 👍 |
…C times - using dayjs (#14100)
started the job as gitpod-build-jx-fix-billing-period-ui.4 because the annotations in the pull request description changed |
started the job as gitpod-build-jx-fix-billing-period-ui.5 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😉
Description
Fix display of billing period boundaries in the dashboard by using only UTC times.
(Note: I did try to use
dayjs
for this, but couldn't figure out how to "force" everything to be UTC, so I fell back on the native Date type. Happy to switch todayjs
if you know how to achieve exactly the same result. 👍)Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide