Skip to content

[code] update stable code to amend default location of portsView #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

[code] update stable code to amend default location of portsView #14102

merged 1 commit into from
Oct 21, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 21, 2022 •
edited by filiptronicek
Loading

Description

Related Issue(s)

Fixes #

How to test

  • Open workspace in preview env with stable code
  • Check version is 1.72.3
  • Exec command by vscode command panel Reset view locations
  • Check if default portsView location is correct (should exists next to Terminals)

Release Notes

Fixes default location of the <kbd>Ports</kbd> view

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mustard-mh
Copy link
Contributor Author

/hold

@jeanp413 jeanp413 marked this pull request as ready for review October 21, 2022 21:17
@jeanp413 jeanp413 requested a review from a team October 21, 2022 21:17
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-vs-pf-stable.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

/unhold

image

@roboquat roboquat merged commit c497372 into main Oct 21, 2022
@roboquat roboquat deleted the hw/vs-pf-stable branch October 21, 2022 21:35
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 21, 2022
@mustard-mh mustard-mh mentioned this pull request Oct 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 jeanp413 approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustard-mh @jeanp413 @filiptronicek @roboquat