Skip to content

[dashboard] Keep showing 'Personal Account' if you have personal projects but no team yet #14128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

When you have Projects under your 'Personal Account' (now being deprecated), but you have no Teams yet, we currently show only a "New Team →" button, with no way to access the projects under your 'Personal Account'. 🐞

This PR makes Gitpod show your 'Personal Account' menu entry again when you're in that specific case (but not if you don't have any Projects there).

Related Issue(s)

Fixes #14002

How to test

  1. Log in to the preview environment
  2. Visit /new to create a Project under your 'Personal Account' manually
  3. Your 'Personal Account' should be accessible from the top menu's "account selector" (without you having to create a team first)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jx-show-personal-account-if-projects.1 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking an early look after seeing @jldec's ping in #14002.

UX LGTM!

Thanks, @jankeromnes!

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 24, 2022

Wow, thanks @gtsiolis for reviewing this so fast ⚡ (before I could even test it myself or mark it ready for review 🤩)

@jankeromnes jankeromnes marked this pull request as ready for review October 24, 2022 15:22
@jankeromnes jankeromnes requested a review from a team October 24, 2022 15:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 24, 2022
@roboquat roboquat merged commit bc4d4c3 into main Oct 24, 2022
@roboquat roboquat deleted the jx/show-personal-account-if-projects branch October 24, 2022 15:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 25, 2022
@jldec jldec changed the title [dashboard] Keep showing 'Personal Account' menu entry if you have personal projects but no team yet [dashboard] Keep showing 'Personal Account' if you have personal projects but no team yet Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For users with no teams the "New Team" button hides the Personal Account with projects
4 participants