[db-sync] Add the d_b_workspace_cluster table to sync config
#14136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Depends on: #14134 (comment) Also, did you announce the rollout to team workspace? It should not affect them. But they should be aware of the impact, etc. |
12 tasks
Yes, that was done here (internal Slack). |
|
We just realized that before merging this we need to switch the table to the "soft deletion" pattern. |
4 tasks
andrew-farries
force-pushed
the
af/sync-workspace-cluster-table
branch
from
e3813e3 to
f1a4a86
Compare
|
We should be able to land this once #14351 is deployed. |
geropl
reviewed
Nov 2, 2022
| name: "d_b_workspace_cluster", | ||
| primaryKeys: ["name", "applicationCluster"], | ||
| timeColumn: "_lastModified", | ||
| deletionColumn: "deleted", |
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
d_b_workspace_clustertable to thedb-syncconfig to start syncing the table.Context
As part of #9198 we want to start syncing the `d_b_workspace_cluster` table with `db-sync`.Currently, the table differs between US and EU regions because each table contains only the data relevant to that region. For example, in the EU table, the
eu70workspace cluster is marked asavailableand theus70cluster iscordoned. In the US clustereu70iscordonedandus70isavailable.In order to sync the table we need to get to a point where there is no difference in the data in the table between EU and US regions.
To do that we will introduce a new field in the table called
applicationClusterwhich records the name of the application cluster to which the record belongs. Thus, for each workspace cluster there will be two rows in Gitpod SaaS:Effectively the new
applicationClustercolumn gives the table an extra dimension so that we can combine both tables (EU and US) into one.#13722 added the column to the table and made
gpctlfill the value whengpctl registering a new workspace cluster. The value is taken from theGITPOD_INSTALLATION_SHORTNAMEenvironment variable inws-manager-bridge.Related Issue(s)
Part of #9198 and #13800
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide