-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ws-manager: Add the workspace status for PodInitialzing phase #14146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-to-creating-phase.1 because the annotations in the pull request description changed |
@@ -0,0 +1,4 @@ | |||
[allowlist] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot pass the precommit hooks without this file because thb golden file has a token and etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, when there are two containers in a pod
Isn't it because we want to add initContainer to chown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to test it because the code change LGTM.
/hold for @sagor999 double check.
Yes, it is. Becase a workspace status doesn't hit the Creating phase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/unhold
Thank you @utam0k! Can confirm this PR did fix the issue with more then one container in the workspace pod. Good find! |
Description
For some reason, when there are two containers in a pod, there is no ContainerCreating phase, but PodInitializing. So we have addressed this issue.
Related Issue(s)
Fixes #14103
How to test
Release Notes
Documentation
No
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide