ws-manager: Add the workspace status for PodInitialzing phase #14146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-to-creating-phase.1 because the annotations in the pull request description changed |
jenting
reviewed
Oct 25, 2022
| @@ -0,0 +1,4 @@ | |||
| [allowlist] | |||
There was a problem hiding this comment.
What's the purpose of this file?
There was a problem hiding this comment.
We cannot pass the precommit hooks without this file because thb golden file has a token and etc.
jenting
reviewed
Oct 25, 2022
jenting
approved these changes
Oct 25, 2022
Yes, it is. Becase a workspace status doesn't hit the Creating phase. |
|
Thank you @utam0k! Can confirm this PR did fix the issue with more then one container in the workspace pod. Good find! |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, when there are two containers in a pod, there is no ContainerCreating phase, but PodInitializing. So we have addressed this issue.
Related Issue(s)
Fixes #14103
How to test
Release Notes
Documentation
No
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide