Skip to content

ws-manager: Add the workspace status for PodInitialzing phase #14146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 25, 2022

Description

For some reason, when there are two containers in a pod, there is no ContainerCreating phase, but PodInitializing. So we have addressed this issue.

Related Issue(s)

Fixes #14103

How to test

Release Notes

NONE

Documentation

No

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@utam0k utam0k requested a review from a team October 25, 2022 08:26
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-creating-phase.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 25, 2022
@@ -0,0 +1,4 @@
[allowlist]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot pass the precommit hooks without this file because thb golden file has a token and etc.

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, when there are two containers in a pod

Isn't it because we want to add initContainer to chown?

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test it because the code change LGTM.

/hold for @sagor999 double check.

@utam0k
Copy link
Contributor Author

utam0k commented Oct 25, 2022

For some reason, when there are two containers in a pod

Isn't it because we want to add initContainer to chown?

Yes, it is. Becase a workspace status doesn't hit the Creating phase.

Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/unhold

@roboquat roboquat merged commit 8200bfb into main Oct 25, 2022
@roboquat roboquat deleted the to/creating-phase branch October 25, 2022 15:04
@sagor999
Copy link
Contributor

Thank you @utam0k! Can confirm this PR did fix the issue with more then one container in the workspace pod. Good find!

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[container-runtime] if workspace pod has more than 2 containers, ws-daemon ExtractCGroupPathFromContainer fails
4 participants