Skip to content

[gitpod-protocol] Add createTeam, joinTeam, getTeamMembers to Go lib #14170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 26, 2022

Description

Adds Team RPCs to Go gitpod protocol library

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team October 26, 2022 05:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 26, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Oct 26, 2022

/werft run

👍 started the job as gitpod-build-mp-protocol-team-apis.1
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/protocol-team-apis branch from c016bb6 to ea25ebf Compare October 26, 2022 14:49
@easyCZ
Copy link
Member Author

easyCZ commented Oct 26, 2022

/werft run

👍 started the job as gitpod-build-mp-protocol-team-apis.3
(with .werft/ from main)

@geropl
Copy link
Member

geropl commented Oct 27, 2022

Starting to review now.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat roboquat merged commit 8accb14 into main Oct 27, 2022
@roboquat roboquat deleted the mp/protocol-team-apis branch October 27, 2022 08:39
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants