Skip to content

Fix 'gp open' command to open files in JetBrains Client instead of the backend IDE #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Oct 26, 2022

Description

Fix gp open command to open files in JetBrains Client instead of the backend IDE.

These changes also affects gp preview command, so it needs to be tested.

How to test

  1. Open the preview environment generated for this branch
  2. Choose the Stable version of IntelliJ IDEA as your preferred editor
  3. Start a workspace using this repository: https://github.com/gitpod-io/spring-petclinic
  4. Verify that the workspace starts successfully
  5. Verify that the IDE opens successfully
  6. Run gp open .gitignore and confirm it opens the .gitignore file in the editor
  7. Run gp open --wait .gitpod.yml and confirm it opens Gitpod Configuration file and will only exit the command line when you click "Release" on the top bar displayed in the editor
  8. Run gp preview https://gitpod.io and confirm Gitpod Website opens in your browser
  9. Repeat the same steps above, but now using the Latest Release (Unstable) version of IntelliJ IDEA

Release Notes

Fix 'gp open' command to open files in JetBrains Client instead of the backend IDE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com

This comment was marked as resolved.

@felladrin felladrin marked this pull request as ready for review October 26, 2022 09:39
@felladrin felladrin requested a review from a team October 26, 2022 09:39
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me, but i have not tried

/hold

@felladrin
Copy link
Contributor Author

I'll publish the screenshots with the results from Preview Environment soon.

@felladrin
Copy link
Contributor Author

felladrin commented Oct 26, 2022

Stable IntelliJ tested ✅

image

image

image

image

@felladrin
Copy link
Contributor Author

felladrin commented Oct 26, 2022

EAP IntelliJ tested ✅

image

image

image

image

/unhold

@roboquat roboquat merged commit 9e1dac1 into main Oct 26, 2022
@roboquat roboquat deleted the jetbrains/fix-gp-open-command branch October 26, 2022 10:05
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 26, 2022
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Oct 26, 2022

🚀

Thanks for fixing this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants