Skip to content

[server] Revert #14185 #14203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2022
Merged

[server] Revert #14185 #14203

merged 2 commits into from
Oct 26, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Oct 26, 2022

Description

Revert #14185.

The metric was added incorrectly and is actually incrementing on all workspace starts, not just image builds.

The metric is re-added correctly in #14204

Related Issue(s)

Part of #12960

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries andrew-farries requested a review from a team October 26, 2022 15:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 26, 2022
@roboquat roboquat merged commit cd8a095 into main Oct 26, 2022
@roboquat roboquat deleted the af/revert-14185 branch October 26, 2022 18:40
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants