Skip to content

Update team creation link in projects #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Oct 26, 2022

Description

Following up from #13920, to update the correct line of code.

How to test

See instructions in #13920.

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@gtsiolis gtsiolis requested a review from a team October 26, 2022 19:19
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 26, 2022
@easyCZ
Copy link
Member

easyCZ commented Oct 26, 2022

Shall we also revert the change in #13920?

@gtsiolis gtsiolis force-pushed the gt/update-team-creation-link branch from df7db53 to 95ce6d7 Compare October 26, 2022 19:26
@gtsiolis
Copy link
Contributor Author

Thanks, @easyCZ! I was about to ask about the change in #13920 since I could not spot any UX difference with that change, but let's revert to be on the safe side.

Updated in 95ce6d7. Let me know if you'd prefer the revert in a separate commit.

Ready-To-Merge.

@easyCZ
Copy link
Member

easyCZ commented Oct 26, 2022

LGTM, just needs a release note.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Oct 26, 2022

Thanks, @easyCZ! 🍻

@roboquat roboquat merged commit 0a0ceb9 into main Oct 26, 2022
@roboquat roboquat deleted the gt/update-team-creation-link branch October 26, 2022 19:32
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants